arunavabasucom / radis-app

A web app for high-resolution infrared molecular spectra using RADIS
https://radis.app
GNU Lesser General Public License v3.0
11 stars 15 forks source link

feature to download the spectrum file (.spec) #619

Closed arunavabasucom closed 2 years ago

arunavabasucom commented 2 years ago

Fixes #211 Fixes #626 Fixes #571

New features :

Values molecule Image
5 mm slit 2000-2300 co Screenshot 2022-08-19 at 4 49 19 PM
15 mm slit 2000-2300 co Screenshot 2022-08-19 at 4 48 47 PM
Screenshot 2022-08-19 at 9 16 11 PM
arunavabasucom commented 2 years ago

👉 References :

https://user-images.githubusercontent.com/73842340/185657767-05d90e2f-0d1e-45b3-9951-65a2b2585373.mp4

Screenshot 2022-08-19 at 9 16 11 PM
arunavabasucom commented 2 years ago
Values molecule Image
5 mm slit 2000-2300 co Screenshot 2022-08-19 at 4 49 19 PM
15 mm slit 2000-2300 co Screenshot 2022-08-19 at 4 48 47 PM
suzil commented 2 years ago

I think the UI behavior of enabling the button can be a little confusing to the user if we fail to plot a spectrum for a given input. If the user inputs something that fails to plot, the download button still becomes enabled and you can still download something.

https://user-images.githubusercontent.com/13723264/185790230-9f1c2984-9cad-4d7a-bd28-81074d4efb56.mov

Maybe we could disable the download button if something isn't plotted OR if the user changes the input form after something gets plotted. Thoughts @erwanp and @arunavabasu-03 ?

erwanp commented 2 years ago

I had suggested this, is it possible ? IT would fix your problem

Just turn it gray whenever you press Calculate. Then visible when the spectrum is calculated and shown. Then gray again when Calculate is pressed again.

https://github.com/suzil/radis-app/pull/619#discussion_r950433123

arunavabasucom commented 2 years ago

Ahh @erwanp !! @suzil is saying that based on the graph plotted or not disable or enable the download button.

erwanp commented 2 years ago

Disabling download after something gets plotted is good; but it's going to take time, and we need to have these changes Merged and tested before Wednesday. Just do Disable download during a calculation and until the graph is plotted for the moment