arunavabasucom / radis-app

A web app for high-resolution infrared molecular spectra using RADIS
https://radis.app
GNU Lesser General Public License v3.0
11 stars 15 forks source link

Add support for overlaying spectra #646

Closed suzil closed 2 years ago

suzil commented 2 years ago

https://user-images.githubusercontent.com/13723264/187048092-1615a7eb-796c-4b19-b3b7-8034fe01a825.mov

(The missing ylabel has been fixed, don't want to re-demo it)

I've changed the UI slightly from the ticket to instead have:

Would a different UI be better?

I hope it's OK @arunavabasu-03 that I took this ticket 🙈

Closes https://github.com/suzil/radis-app/issues/452

erwanp commented 2 years ago

@minouHub you'll love it

suzil commented 2 years ago

There's some issue with the species I still need to figure out (you'll notice duplicated labels on the legend), just noticed it

erwanp commented 2 years ago

This is a very game-changing feature ! From a physics point of view, it allows very interesting thing :

I like the Add to Plot syntax rather than the originally suggested Clear button. I'd keep that. Maybe we could rename "Create Plot" to "New Plot" ?

suzil commented 2 years ago
Screen Shot 2022-08-27 at 6 43 05 PM

@erwanp how is this?

suzil commented 2 years ago

Fixed unit of pressure from atm to bar ^

erwanp commented 2 years ago

Nice and clear ! Can we add one comma after the database name in the label, not to read "Hitran Pressure" as one block?

suzil commented 2 years ago
Screen Shot 2022-08-27 at 7 03 57 PM

@erwanp updated to add that comma, anything else?

erwanp commented 2 years ago

LGTM