search

arunavabasucom / radis-app

A web app for high-resolution infrared molecular spectra using RADIS
https://radis.app
GNU Lesser General Public License v3.0
11 stars 15 forks source link

storybook added #688

Closed Mohit-Aasirwal closed 1 year ago

Mohit-Aasirwal commented 1 year ago

Title:

Storybook added for templating the components.

Description:

done with setting up UI for app and added storybook. Done with running on local machine and linting with ESlint.

Tasks done:

  1. Setting up the app on local machine.
  2. doing initial changes and fixing some platform issues to make app work.
  3. setting storybook for app.
  4. linting and code compilation

Related Issues

Successfully closes #669

Screenshots

image Screenshot (416)

major changes

  1. disabled react imports in stories to cope up with eslint.
  2. disabled prettier to avoid "Delete CR" error.

Thanks!

suzil commented 1 year ago

Running yarn storybook is failing for me. I think we're missing some configuration files?

Screenshot 2023-03-29 at 9 15 10 PM

Also these stories are not related to any components that are in this repo. It would be much more helpful to have some stories for components from this repo.

Mohit-Aasirwal commented 1 year ago

I've found that .storybook is needed to run the storybook on local machine. you can try with npx sb init if you haven't already. thanks.

arunavabasucom commented 1 year ago

@Mohit-Aasirwal thanks for this PR, closing this for now. I hope you will keep contributing.