search

arunghosh / react-heatmap-grid

A react component for heatmap visualisation in grid layout
https://codesandbox.io/s/r4rvwkl3yn
MIT License
76 stars 42 forks source link

Cell positions offset when using a small height #170

Closed d-beltran closed 4 years ago

d-beltran commented 4 years ago

Hi :)

I may have found a bug. When the 'height' parameter is small (e.g. 5) cell rows with y label are displayed separated by a white space (see the figure below)

Captura de pantalla de 2020-05-19 14-03-47 Captura de pantalla de 2020-05-19 13-51-06

I tried to fix this with other parameters but I didn't succeed.

However there is a small change in the code which seems to fix this. I have not deep checked if this modification has side effects, but it may be useful.

In the 'DataGrid.jsx' script: Captura de pantalla de 2020-05-19 13-58-18 Captura de pantalla de 2020-05-19 14-01-11

I am new in GitHub, so I apologize if this is not the correct way to suggest changes. If there is a 'suggest commit' protocol please point me how to do it and I will.

Cheers

arunghosh commented 4 years ago

@d-beltran Thank you very for conveying the issue and the fix. This is fixed in version v0.8.2.