arunkumar9t2 / lynket-browser

🌐 A better browser for Android using the Custom Tab protocol. Previously called Chromer.
Other
480 stars 81 forks source link

Off-by-one error in Web Heads mode #101

Closed dgw closed 2 years ago

dgw commented 5 years ago

Lynket on my Razer Phone (Android 8.1, Lynket version 2.0.1) somehow got into an off-by-one state where if one Web Head was open, it displayed "0" on the badge.

I have Web Heads set to close once clicked. When I clicked the second-to-last Web Head (there should still be one more to open after I finished reading that page), the last one disappeared.

Force closing Lynket seems to have resolved the issue, and I can't find any way to generate a logcat. It started probably a couple days ago now, so chances are the genesis of the issue wouldn't be in the log anyway… But if there is a way to make a log, do let me know so I can generate one if this happens again.

arunkumar9t2 commented 5 years ago

Hey thanks for letting me know! I have planned a huge rework in webheads and will definitely address this.

dgw commented 5 years ago

Just encountered this again in Lynket version 2.0.2. Same device & OS version. See the "0" in this screenshot:

dgw commented 2 years ago

I haven't seen this happen again, in nearly 3 years. It's probably time to close this until/unless it can be reproduced again.

arunkumar9t2 commented 2 years ago

Thanks for following through. Progress has been slow on maintenance update although I still intend to work on improvements when time permits.