search

arunkumar9t2 / lynket-browser

🌐 A better browser for Android using the Custom Tab protocol. Previously called Chromer.
Other
477 stars 81 forks source link

Enabling Incognito mode via quick settings doesn't actually turn it on (have to open the app to enable it) #132

Open dragon788 opened 4 years ago

dragon788 commented 4 years ago

I was pretty sure the "Incognito Mode" toggle in Quick Settings is from Lynket, but while I had a couple other Lynket floating bubbles (Web Heads) open I tried enabling Incognito and opening a link, but it just opened another Web Head rather than using the slide in full Web View style that is supposed to be forced for Incognito I believe?

I tried toggling it in the app and that is how it appeared to work when I opened another link. I do like that enabling Incognito doesn't clear the history, just prevents new items from being added while it is enabled.

IzzySoft commented 4 years ago

@dragon788 where did you find it in the app? I was looking for it in vain (same for clearing cookies etc). What place did I miss to check? Or is Lynket always in incognito modus if it cannot find any custom-tab capable browser and hence falls back to webview only?

dragon788 commented 4 years ago

If you go into the history you can turn on incognito mode.

The quick settings is shown in the tips screen.

IzzySoft commented 4 years ago

Ah, thanks! Who'd expect it there … I found the quick settings tile before, but not the setting inside the app. Now that I found the latter, I can confirm your issue: I had turned on incognito via the tile, but it was still turned off in the app. Further, turning it off again using the tile doesn't turn it off in the app. So there seems to be no connection between the tile and the app.

Apart from that, I still couldn't find where to manually delete cookies etc. (for browsing sessions which didn't have incognito enabled).

dragon788 commented 4 years ago

I believe since it uses the Chrome (or another browser you select) for rendering the web view if you open Chrome the sites you have visited may end up in the cookies there.

IzzySoft commented 4 years ago

And if you have no "compatible" browser installed – or just selected "System Webview" for rendering?

@arunkumar9t2 could you please shed some light? Does clearing the history take care for that (and thus compare to what other browsers have as separate entries for "cookies, site data, browsing history")?

arunkumar9t2 commented 4 years ago

Thanks for letting me know. The incognito tile <-> app preference seems to be an issue, yes. I will fix it. @IzzySoft as for you questions

hence falls back to webview only Yes, when no valid providers are there, it falls back to webview but records entries. The entry recording is stopped when disabling history/enabling incognito mode.

The reason incognito forces WebView is because Lynket at the moment does not have access to launch Chrome Custom Tabs in incognito mode. To circumvent that I use WebView to render pages. At the moment, I do not expose fine grained settings like that, will consider adding it.

IzzySoft commented 4 years ago

Thanks! Btw, while trying the app (with only webview available) I noticed reader mode is quite unusable for many sites. Looks fine, yes, but half of the content is missing (and I mean content, not the distractions we all expect to be missing there) – for example, from 5 paragraphs only 2 are shown. Is that a known issue? That, together with the fact that "normal windows" appear as separate entries in recently-used is keeping me from using it (aside from Crashlytics).