arunkumar9t2 / lynket-browser

🌐 A better browser for Android using the Custom Tab protocol. Previously called Chromer.
Other
477 stars 81 forks source link

Bug: & not escaped in searches #151

Open Efreak opened 3 years ago

Efreak commented 3 years ago

It seems that lynket isn't properly escaping special characters in search URLs. I tapped a suggestion for life & times, and got a search for life. I tried typing it out myself instead of using a suggestion, and the same issue applied. The URL lynket sends me to is https://duckduckgo.com/?q=life+&+times=&ia=web; note that the & in the query is not escaped.

An easy way to tell if the ampersand specifically should be escaped (without trying to parse the entry as a URL) is to check for spaces indicating a search instead of a URL.

Edit: I thought I was clicking a close window button that unexpectedly popped up. Thx, GitHub app...