arunkumar9t2 / scabbard

šŸ—” A tool to visualize Dagger 2 dependency graphs
https://arunkumar9t2.github.io/scabbard
Apache License 2.0
852 stars 35 forks source link

Separate full graph validation images and handle errors #34

Closed arunkumar9t2 closed 4 years ago

arunkumar9t2 commented 4 years ago

Closes #26

Type of change

Description

Previously when both fullBindingGraphValidation and failOnError were enabled, build will fail due to filerexceptions. There were already some ceremony to handle filerexception but it was not great - not working as expected. This PR properly addresses the issue by safely handling such exceptions and taking measures to avoid that exception by prefixing files with full_. This way Java's Filer won't complain that resource was already opened.

But this has the side effect of generating multiple graphs per component, the pruned one and full one. So the intellij plugin is also updated to handle such scenario.

Motivation and Context

Fix unnecessary build errors

How did you test it?

Add full-binding-graph-test module to test this flag.

Checklist

Next steps

Consider updating intellij plugin to navigation popup in case multiple matches are found.

Screenshots / GIFs