search

arunkumarmunusamy / bitfighter

Automatically exported from code.google.com/p/bitfighter
Other
0 stars 0 forks source link

Don't send TextItems to players who shouldn't see them #448

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I had to either remove or fix the check in TextItem rendering that checks if 
the player is on the right team to see a TextItem.  It would make more sense to 
never send a TextItem to a player if they shouldn't see it, and then render 
them all.

Note that this will have to work when players change teams.

Original issue reported on code.google.com by watusim...@bitfighter.org on 6 Jul 2014 at 12:20

GoogleCodeExporter commented 9 years ago 
The same logic should be applied to LineItems.  And Mines too!

Original comment by watusim...@bitfighter.org on 6 Jul 2014 at 12:22

GoogleCodeExporter commented 9 years ago 
Wait, not mines... you can see enemy mines.

Original comment by watusim...@bitfighter.org on 6 Jul 2014 at 12:30

GoogleCodeExporter commented 9 years ago 
Same logic to cloaked players eventually?

Original comment by corteocarl on 7 Sep 2014 at 12:07

GoogleCodeExporter commented 9 years ago 
Yes, probably.  Players currently need to know location of cloaked players 
because cloakers emit a sound and block the stars behind them.  We've all 
agreed that these features should be removed, at which point sending the 
location of cloaked players will be unnecessary.

Original comment by watusim...@bitfighter.org on 7 Sep 2014 at 5:15

GoogleCodeExporter commented 9 years ago 
This has now been fixed.  There is some follow-on work to be done, but this 
case can be closed.

Original comment by watusim...@bitfighter.org on 23 Feb 2015 at 6:53