search

arunoda / react-komposer

Feed data into React components by composing containers.
MIT License
733 stars 70 forks source link

Should mobx be moved from devDependencies to dependencies in package.json? #103

Closed mkdbns closed 8 years ago

mkdbns commented 8 years ago

As of the last release, we are seeing the following error in the browser console for our application:

Uncaught Error: Cannot find module 'mobx'

Coming from:

node_modules.react-komposer.dist.composers.with_mobx.js

Adding mobx to our dependencies seems to resolve the issue. Seems like mobx should be moved from devDependencies to dependencies in your package.json?

arunoda commented 8 years ago

Yes it is. I am working on it.

arunoda commented 8 years ago

This should be fixed with the latest release. Update the package.

SachaG commented 8 years ago

Why does Komposer need to depend on mobx? I thought it was supposed to work with Redux, Meteor, etc. independently ?