search

arunoda / react-komposer

Feed data into React components by composing containers.
MIT License
732 stars 70 forks source link

add sample how to migrate composeWithTracker to v2 #130

Closed macrozone closed 7 years ago

macrozone commented 7 years ago

See title,

migration to v2 looks doable, but it's not totally clear. There is also no migration path for meteor-users that still use composeWithTracker.

We should provide such an example or a reference-implementation of a composer that uses tracker underneath

arunoda commented 7 years ago

Yep. I will do it today.

arunoda commented 7 years ago

Added it here: https://github.com/arunoda/react-komposer#for-meteors-tracker

macrozone commented 7 years ago

perfect, thx!

TobyEalden commented 7 years ago

still looks a bit confusing to me - use of reactiveMapper for parameter name and actual function, plus shouldn't reactiveMapper mapper return something (or should check for null trackerCleanup before calling it) ?