search

arunoda / react-komposer

Feed data into React components by composing containers.
MIT License
732 stars 70 forks source link

Make refs optional #166

Closed Hypnosphi closed 6 years ago

Hypnosphi commented 6 years ago

React doesn't support refs for stateless functional components (SFCs), and starting from next major version, it will warn about it (see https://github.com/storybooks/storybook/issues/1539).

This PR makes it possible to opt out of setting child ref, so that compose can be used with SFCs.

chrishearn commented 6 years ago

@arunoda Any chance of getting this PR merged please? The issue is littering my console with errors on React 16 (which is due to be released in the next few days). Thanks.

@Hypnosphi Thanks for raising this PR! Hopefully it will be merged soon.

jshimko commented 6 years ago

@chrishearn I don't think this project is maintained anymore. You may want to fork it or just add the code to your own project. There's not too much there, so it's pretty straightforward to just maintain your own version.

danielduan commented 6 years ago

We forked, fixed, and published this package as @storybook/react-komposer if you're interested in using it. @chrishearn @jshimko

@Hypnosphi since this PR is made from our master branch, I think we can just close this for now.