Possible bug in anomaly_detection.py

arunppsg / TadGAN

Code for the paper "TadGAN: Time Series Anomaly Detection Using Generative Adversarial Networks"

MIT License

153 stars 34 forks source link

Possible bug in anomaly_detection.py #3

Closed shyam1998 closed 3 years ago

shyam1998 commented 3 years ago

In anomaly_detection.py line 105, you calculate the standard deviation of the mean value (which is a scalar) and it makes no sense. I think it should be window_std = np.std(window_elts)

arunppsg commented 3 years ago

Hey, Thanks for noticing it. You are right. Will you be interested in fixing it?

shyam1998 commented 3 years ago

@arunppsg I just made a pull request.

arunppsg commented 3 years ago

Thanks for it. Will close this issue.