search

arunshekher / mentions

Github, twitter or other social sites like user mention plugin for e107 CMS
GNU Affero General Public License v3.0
6 stars 2 forks source link

tilde ~ not working in your mention app #14

Open wrxxy opened 6 years ago

wrxxy commented 6 years ago

Hi arun just letting you know that I have tried your plugin and seems to work great however as I am in a gaming clan and most of our names use the special character tilde ~ your mentions don't work, not sure if you know about it just thought you should know.......... image

arunshekher commented 5 years ago

Hi @wrxxy, Thank you for reporting, With this particular plugin behavior I was strictly following e107 v2 specifications for usernames, which doesn’t allow characters such as ~ in username only allows underscore(_)and dot( . ). I understand that it will lead to issues such as yours with v1 upgraded sites, v1 let lot more punctuation and special characters in username (asterisk, space, @ sign, and parenthesis and lot more I guess). Those characters will break the SEO friendly/pretty URLs to user profiles in v2. But if you’re using the classic URL format (with query string) the url to user profile will work as intended. But it could also have other far fetched implications in v2, which I’m not aware of.

So right now my thoughts are fragmented as what to do about it in the plugin. May be I will allow this with an option in the admin area in a future update, but not quite sure as how well it will work out! I'll update you on this thread when it becomes available.

wrxxy commented 5 years ago

Thx for the update Arun, i await your update. Regards

On Mon, Dec 31, 2018 at 9:26 AM Arun S. Sekher notifications@github.com<mailto:notifications@github.com> wrote:

Hi @wrxxyhttps://github.com/wrxxy, Thank you for reporting, With this particular plugin behavior I was strictly following e107 v2 specifications for usernames, which doesn’t allow characters such as ~ in username only allows underscore(_)and dot( . ). I understand that it will lead to issues such as yours with v1 upgraded sites, v1 let lot more punctuation and special characters in username (asteisk, space, @ sign, and parenthesis and lot more I guess). Those characters will break the SEO friendly/pretty URLs to user profiles in v2. But if you’re using the classic URL format (with query string) the url to user profile will work as intended. But it could also have other far fetched implications in v2, which I’m not aware of.

So right now my thoughts are fragmented as what to do about it in the plugin. May be I will allow this with an option in the admin area in a future update, but not quite sure as how well it will work out! I'll update you on this thread when it becomes available.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/arunshekher/mentions/issues/14#issuecomment-450590966, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMdcAZ1oXyiwTJyWGZ_ZVt4L_0DUn9PAks5u-T2YgaJpZM4WCgkr.