nesquena
commented
10 years ago :+1: Nice work overall. A few thoughts:
- Consider adding endless pagination to the timeline
- Good to see you refreshed the timeline after compose
- Consider adding the character count for Compose Activity to limit to 140. See this event handler for more details.
- Consider adding ActiveAndroid to the
TweetandUser. See the persistence guide and this other guide for more details.
I have provided a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.
2) Am using api - account/verify_credentials.json to get the current logged in user's info to be shown on the action bar as well as the compose screen( data sent through intent)
Great
3) Also added refresh button on the actionbar to allow user to refresh the home feed.
Great
4) When i am on the homefeed and I click back button, it goes back to loginactivity and then immediately triggers homefeed again. Hence, reloads the homefeed . It dosen't exit the app, how do i make sure it exits the app? I assume the back button by default would finish the activity.
Easiest way to fix this is try adding noHistory property to the LoginActivity in the manifest.
/cc @nesquena @timothy1ee
User stories included -
User can sign in using OAuth login flow User can view last 25 tweets from their home timeline User can compose a new tweet User can click a “Compose” icon in the Action Bar on the top right User will have a Compose view opened User can enter a message and hit a button to Post User should be taken back to home timeline with new tweet visible
Notes and Questions - 1) When there is no network , it would just toast - no network . Have not implemented the persistence yet. 2) Am using api - account/verify_credentials.json to get the current logged in user's info to be shown on the action bar as well as the compose screen( data sent through intent) 3) Also added refresh button on the actionbar to allow user to refresh the home feed. 4) When i am on the homefeed and I click back button, it goes back to loginactivity and then immediately triggers homefeed again. Hence, reloads the homefeed . It dosen't exit the app, how do i make sure it exits the app? I assume the back button by default would finish the activity.