search

arunthampi / relax

Bots-as-a-Service for Slack
Mozilla Public License 2.0
169 stars 23 forks source link

possible to start the same bot more than once #26

Open jmanian opened 8 years ago

jmanian commented 8 years ago

Maybe this is intentional or unavoidable, but I noticed that it's possible to start the same bot more than once.

For example:

  1. I restart Relax, so that it's running all my bots (exactly once each).
  2. I manually start a particular bot n times by calling Relax::Bot.start!(uid, token) from irb.
  3. I send a message to that bot.
  4. Sending message_new for this user and channel and sending event back to client each appear n + 1 times in the logs, followed immediately by ignoring, not sending event back to client n times.

It's not a problem, because it ignores all but 1 of the copies of the message, and puts only 1 event into redis. But I was surprised that it was possible to start the same bot more than once.

arunthampi commented 8 years ago

@jmanian thanks for reporting this. So the expected behavior is that it should stop the currently running bot and start it again rather than spin up multiple instances of the bot -- let me look into why this is happening.

brianpgerson commented 7 years ago

Was there any ever resolution with this? I see the same thing.