FYI (no code review required) - be aware that a great renaming has taken place. Both of handler names and output names.
This will break existing elara configs out in the wild
volume_counts --> link_vehicle_counts
passenger_counts --> link_passenger_counts
stop_interactions --> stop_passenger_counts
waiting_times --> stop_passenger_waiting
mode_share --> mode_shares 🙄
...
So for example volume_counts_car_total.csv is now link_vehicle_counts_car_total.csv.
The new pattern for outputs is <handler_name><option><suffix (eg alightings or total)>.<file extension>
So for example stop_interactions_alightings_bus.csv would now be stop_passenger_interactions_bus_alightings.csv.
Was this all worth it?
Do not ask this question.
But I argue that as Elara expands some conventions for naming things are reqired. 🤷♂️
@Theodore-Chatziioannou please note that I split your breakdown postprocessors into separate handlers (trip_duration_breakdown and trip_euclid_distance_breakdown). I should do the same with boardings and alightings in future to be consistent.
FYI (no code review required) - be aware that a great renaming has taken place. Both of handler names and output names.
This will break existing elara configs out in the wild
volume_counts-->link_vehicle_countspassenger_counts-->link_passenger_countsstop_interactions-->stop_passenger_countswaiting_times-->stop_passenger_waitingmode_share-->mode_shares🙄So for example
volume_counts_car_total.csvis nowlink_vehicle_counts_car_total.csv.The new pattern for outputs is
<handler_name><option><suffix (eg alightings or total)>.<file extension>So for example
stop_interactions_alightings_bus.csvwould now bestop_passenger_interactions_bus_alightings.csv.Was this all worth it? Do not ask this question.
But I argue that as Elara expands some conventions for naming things are reqired. 🤷♂️
@Theodore-Chatziioannou please note that I split your breakdown postprocessors into separate handlers (
trip_duration_breakdownandtrip_euclid_distance_breakdown). I should do the same with boardings and alightings in future to be consistent.