arup-group / gelato

Gelato turns MATSim outputs into transport sustainability KPI metrics
GNU General Public License v3.0
9 stars 1 forks source link

Fix bus congestion #43

Closed KasiaKoz closed 7 months ago

KasiaKoz commented 7 months ago

Resolves #38 Infinite link speed led to missing data when mean is computed. We don't have testing in this part of the code, so I added something to fill that hole a little bit. It's nothing great, as we would like to change the api eventually, I just did the bare minimum to be able to recreate the problem and then see that the fix is working. It's a builder for the tablesaw KPI calculator, ~it relies on some handy MATSim default scenario creator~. At the minimum it creates something that results in all empty tables in the calculator, so minimal behaviour can be added and tested.

KasiaKoz commented 7 months ago

Reworked the kpi calculator builder, moving away from matsim's scenario builder. Each component has it's own builder. They are mostly ok, except the legs and trips builders, I think they are mostly placeholders for now and might need a bit more finessing before being properly useful, plus they rely on tablesaw Tables which might not be good (guava tables might be a better choice, but that choice should be driven by need, which I don't have at this time)