search

arup-group / gelato

Gelato turns MATSim outputs into transport sustainability KPI metrics
GNU General Public License v3.0
10 stars 1 forks source link

Add ev emissions #80

Closed divyasharma-arup closed 7 months ago

divyasharma-arup commented 7 months ago

Adding default EV emissions factors for DRT to Gelato. Below are the changes:

  1. Added EV default values to MatsimUtils.java. Right now, this default value only applies to DRT, not cars. The default permutations may expand one day, and we may need to be aware of a different solution that doesn't require managing default values in this manner.
  2. Updated the expected-kpi-ghg.csv.gz file for integration-test-data/drt-matsim-outputs I'm not sure if any other relevant GHG files need to be updated elsewhere, please check.
  3. Updated documentation to reference where these default values are coming from. Right now, I'm referencing links and my only concern is if these files get moved somewhere and make the link no longer valid. Is it common practice to copy over relevant pdfs to repos? Not a problem for now, but am aware that we may need to maintain documentation for default assumptions made.
mfitz commented 7 months ago

Is there a corresponding issue for this @divyasharma-arup ?

divyasharma-arup commented 7 months ago

no :( I was thinking perhaps I should make one?

mfitz commented 7 months ago

no :( I was thinking perhaps I should make one?

Yes, good idea 😄

mfitz commented 7 months ago

Can you show the before and after @divyasharma-arup ?

divyasharma-arup commented 7 months ago

Two views of the change due to this PR:

  1. Confirming that DRT now has default values of "EV" and Emissions factors: Before: Screenshot 2024-04-10 at 17 43 16

After: Screenshot 2024-04-10 at 17 43 27

  1. The total emissions have now increased in the DRT outputs for Paris East due to this addition. Before: Screenshot 2024-04-10 at 17 43 53

After: Screenshot 2024-04-10 at 17 44 08

divyasharma-arup commented 7 months ago

Updated changelog!