Elevation script fixes - Githubissues

arup-group / genet

Manipulate MATSim networks via a Python API.

MIT License

45 stars 9 forks source link

Elevation script fixes #170

Closed KasiaKoz closed 1 year ago

KasiaKoz commented 1 year ago

Fixes:

clashing argument flags -ws
import genet.utils.elevation as elevation being overwritten by elevation = args['elevation'] and preventing write_slope_to_object_attribute_file

As a bonus:

gets rid of elevation_output_dir = os.path.join(output_dir, 'elevation') it's a needless extra folder (nothing gets saved anywhere else). User can decide if they want outputs saved to a folder called elevation or not

KasiaKoz commented 1 year ago

I think we say this every time, but it feels like we could do with some testing around the functionality in these scripts (which I think we've also talked about collecting into a CLI, right?).

yeah, it's been on the (jira) cards for a while (unfortunately I'm struggling to find the card right now - I already started matching up some example inputs to the scripts on the card)

mfitz commented 1 year ago

Dunno about Jira, but there is https://github.com/arup-group/genet/issues/127 @KasiaKoz