search

arup-group / genet

Manipulate MATSim networks via a Python API.
MIT License
45 stars 9 forks source link

Refine cli #203

Closed KasiaKoz closed 7 months ago

KasiaKoz commented 1 year ago

Moved genet and non-cli code out of the main cli module.

On the side - the genet help command feels a bit slow. I thought maybe moving and tidying up the imports would speed it up, it did a little but not as much as I hoped.

KasiaKoz commented 1 year ago

I was also surprised to find almost no changes to test code - why is that? Is most of the code that moved untested?

@mfitz It's tested via cli commands, I could add testing the functions as well, but it would be almost exactly the same kind of tests, duplicating things. These are more on the integration side of testing too so not super fast to run. (and the rest of the code used within the recipe functions is unit tested throughout genet, the recipe functions just use those in a specific way to use genet..)

KasiaKoz commented 1 year ago

@mfitz I tidied up the logging config which was in a couple of places, renamed the module and improved testing to separate the testing of recipes code and cli just testing that it calls on the right function with the right arguments.