search

arup-group / genet

Manipulate MATSim networks via a Python API.
MIT License
45 stars 9 forks source link

Update install to rely on mamba / conda envs only #214

Closed brynpickering closed 10 months ago

brynpickering commented 11 months ago

Somewhat supersedes #212, but is in line with the steps that #188 was broken into.

@KasiaKoz the CBC issue is solved by explictly including it in the creation of the mamba environment. I'm chasing up the CBC devs to get the windows version sorted but until then it has to be added explicitly in the install instruction (no different to now tbh) and CI tests on windows will (once I push the fix) skip tests that require CBC.

codecov-commenter commented 11 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

brynpickering commented 11 months ago

Runs on Windows will only start passing once #210 is merged in (to clean up notebook names)

brynpickering commented 11 months ago

RE image size, I think it should reduce. However, I can't verify this as I've got local comparisons based on different container platforms (it can't find conda packages on Linux ARM so I have forced this branch to run in an AMD container [how does that even work?!]). Will wait to have an updated CodeBuild on AWS to see the comparison on there.

brynpickering commented 11 months ago

@mfitz RE image size. It is smaller than the old image (incl. NodeJS) by about 5% but larger than the image in #212 by about 6%.

brynpickering commented 11 months ago

@KasiaKoz I had to make another change for things to work on Windows: remove : from filenames. This affects one of GeNet's outputs: vph_all_modes_within_{h - 1}:30-{h}:30.geojson. I opted for _ to replace :.