Closed KasiaKoz closed 9 months ago
The bug fix looks good, but I've queried the conversion from list to set - are we okay with losing duplicate elements? Can this cause a problem?
right now we're ok and that's the expected behaviour, we have an issue: https://github.com/arup-group/genet/issues/125 so it's known and if this becomes a problem we can start a debate there on what should happen
Also - is there an issue for this bug?
No, I only noticed it when I looked at another bug, that was documented: https://github.com/arup-group/genet/issues/156
Made an issue for the bug and updated the PR description
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
127fcf0
) 92.08% compared to head (d0891cf
) 92.08%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes https://github.com/arup-group/genet/issues/220 The java array types were being read to a set with extra unnecessary characters.
E.g. given:
would be read to
This is now fixed to give:
Added a test to catch the problem: