search

arup-group / pam

Generate and modify transport demand scenarios via a Python API.
MIT License
55 stars 21 forks source link

Try updating GDAL #266

Closed brynpickering closed 6 months ago

brynpickering commented 9 months ago

@Theodore-Chatziioannou was having problems on Windows with GDAL v3.6 but with this relatively strict dependency pinning we might be causing other downstream issues in https://github.com/arup-group/ersa/pull/56 so I'm trying out updating the pinning to skip v3.6 and seeing what the CI thinks about it.

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer(s). You can add extra checklist items here if required by the PR.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (07813c8) 86.84% compared to head (c32f41c) 87.57%. Report is 161 commits behind head on main.

Files Patch % Lines
pam/planner/choice_location.py 80.85% 12 Missing and 6 partials :warning:
pam/planner/utils_planner.py 76.59% 9 Missing and 2 partials :warning:
pam/write/matsim.py 59.25% 6 Missing and 5 partials :warning:
pam/read/diary.py 66.66% 6 Missing and 4 partials :warning:
pam/optimise/grid.py 70.00% 9 Missing :warning:
pam/vehicles.py 94.97% 4 Missing and 5 partials :warning:
pam/core.py 87.87% 7 Missing and 1 partial :warning:
pam/plot/plans.py 81.81% 3 Missing and 3 partials :warning:
pam/optimise/random.py 71.42% 2 Missing and 2 partials :warning:
pam/activity.py 50.00% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #266 +/- ## ========================================== + Coverage 86.84% 87.57% +0.73% ========================================== Files 49 48 -1 Lines 5496 5747 +251 Branches 1372 1374 +2 ========================================== + Hits 4773 5033 +260 + Misses 462 445 -17 - Partials 261 269 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brynpickering commented 9 months ago

Segementation faults encountered in some Windows runs, so I'll return to this once this issue is resolved: https://github.com/OSGeo/gdal/issues/8959