search

arusahni / ngtweet

Easily embed Twitter widgets into your Angular application! No more having to kludge together a Twitter script loader, or manage embed state on route/visibility change.
http://arusahni.github.io/ngtweet/
MIT License
34 stars 22 forks source link

function to configure the url of widget.js source file #10

Closed salazarr-js closed 8 years ago

salazarr-js commented 8 years ago

the //platform.twitter.widget.js url give several problems in compiled apps with cordova, because the system take that url like a file file://, Cordova bug also widget.js always is loaded from internet, which in some cases isn't a good practice for loading time, I resolved this problem including "https://" to the default URL and a function to change it if want to load it from local.

salazarr-js commented 8 years ago

posible solution to #7

arusahni commented 8 years ago

Looks good! I might want to move from suggesting run to config, but that's a more intrusive change. Thanks for the MR!