search

arusahni / ngtweet

Easily embed Twitter widgets into your Angular application! No more having to kludge together a Twitter script loader, or manage embed state on route/visibility change.
http://arusahni.github.io/ngtweet/
MIT License
34 stars 22 forks source link

dynamically load timeline #35

Closed nemanjam closed 6 years ago

nemanjam commented 6 years ago

I am using this to load collection timeline and it is working when page loads, and I want to change timeline on click event by changing twitter-timeline-id of another collection but with no success.

I am calling twttr.widgets.load(); after twitter-timeline-id change with no success.

<twitter-timeline twitter-timeline-type="collection" twitter-timeline-id="'731630017813684224'" twitter-timeline-options='{"chrome": "noheader"}'> </twitter-timeline>

arusahni commented 6 years ago

At first glance, it definitely seems that the directive doesn't support it. However, it can, and should (at least in order to maintain parity with the twitter-widget directive). I'll try to address this within the next week or so.

arusahni commented 6 years ago

@nemanjam I pushed an update that adds the functionality. Can you test the latest version on the develop branch and let me know if it addresses your issue?

nemanjam commented 6 years ago

How to do bower update of develop branch?

bower update ngtweet#develop gives bower ENOTINS Package ngtweet#develop is not installed.

arusahni commented 6 years ago

You may need to upgrade bower to the latest version.

On Wed, Jan 24, 2018 at 8:54 AM Nemanja Mitic notifications@github.com wrote:

How to do bower update of develop branch?

bower update ngtweet#develop gives bower ENOTINS Package ngtweet#develop is not installed.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/arusahni/ngtweet/issues/35#issuecomment-360141995, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIg30jTDN_J7-AMuzm715Pts7LETLHJks5tNzYggaJpZM4RdmXU .

nemanjam commented 6 years ago

It is bower -v 1.8.2.

No tag found that was able to satisfy 1.0.0 Additional error details: Available versions in https://github.com/arusahni/ngtweet.git: 0.6.2, 0.6.1, 0.6.0, 0.5.1, 0.5.0, 0.4.0, 0.3.1, 0.3.0, 0.2.0, 0.1.2, 0.1.1, 0.1.0

arusahni commented 6 years ago

What if you run bower install ngtweet#develop?

On Wed, Jan 24, 2018 at 9:10 AM Nemanja Mitic notifications@github.com wrote:

It is bower -v 1.8.2.

No tag found that was able to satisfy 1.0.0 Additional error details: Available versions in https://github.com/arusahni/ngtweet.git: 0.6.2, 0.6.1, 0.6.0, 0.5.1, 0.5.0, 0.4.0, 0.3.1, 0.3.0, 0.2.0, 0.1.2, 0.1.1, 0.1.0

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/arusahni/ngtweet/issues/35#issuecomment-360146955, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIg35v_s62jA_NE4SXFLiS8Ul5FvzCOks5tNzm4gaJpZM4RdmXU .

nemanjam commented 6 years ago 

bower not-cached    https://github.com/arusahni/ngtweet.git#1.0.0
bower resolve       https://github.com/arusahni/ngtweet.git#1.0.0
bower not-cached    https://github.com/arusahni/ngtweet.git#develop
bower resolve       https://github.com/arusahni/ngtweet.git#develop
bower download      https://github.com/arusahni/ngtweet/archive/develop.tar.gz
bower extract       ngtweet#develop archive.tar.gz
bower resolved      https://github.com/arusahni/ngtweet.git#9dc2c7af84
bower ENORESTARGET  No tag found that was able to satisfy 1.0.0```
arusahni commented 6 years ago

Interesting. I haven't touched bower in years, so I'm flying blind here. Can you try installing via the zip? https://github.com/arusahni/ngtweet/archive/develop.zip.

nemanjam commented 6 years ago

Demo is working. In my project is working also.

arusahni commented 6 years ago

Cool. I'll cut a release. Thanks for verifying!

arusahni commented 6 years ago

This has been released as v1.0.0!