arvatoSCM / dockerize-magento2

Composer package for dockerizing Magento 2
Apache License 2.0
112 stars 56 forks source link

workflow: no magento core files or dockerize-magento2 in project repo #21

Open WileESpaghetti opened 7 years ago

WileESpaghetti commented 7 years ago

For our git repositories, we like to only have the stuff that we've written or changed checked in. Everything else is pulled in via composer install when someone checks out the project.

I don't think you can do this with the way dockerize-magento2 currently works. It seems like it's only intended to be installed once when you start the project with your repository containing both magento core files and dockerize-magento2 files.

...So example scenario We start the project. The initial commit is a barebones composer.json with magento listed as a dependency and with dockerize-magento2 as a dependency. We also have a .gitignore with magento core files listed.

Our development MySQL has different credentials, so we update our .env file and check it in.

New developer starts the project

Currently when we do this the composer install overwrites our .env file and stuff in config/ with the dockerize-magento2 defaults