arve0 / feathers-mongodb-fuzzy-search

Add fuzzy $search to mongodb service.find queries
https://www.npmjs.com/package/feathers-mongodb-fuzzy-search
40 stars 10 forks source link

Added lock files for those using Yarn & NPM >= 5 #1

Closed claustres closed 7 years ago

arve0 commented 7 years ago

Thanks 👍 I'm aware that yarn was the first in town to implement package-lock files and adding reproducible installs, though I do not like the segmentation that yarn adds to the ecosystem. To me, npm is good enough, and my personal opinion is that yarn should support package-lock.json.

Anyhow, if you remove yarn.lock, I will merge.

claustres commented 7 years ago

You are not right about Yarn been the first IMHO, NPM have supported https://docs.npmjs.com/cli/shrinkwrap for a long time, that was simply not the default behavior.

I think it is worth the effort supporting all tools in the ecosystem if not too much complicated (in this case this is just one more file). Anyway, if really don't want to support yarn close this PR.