search

arvehj / jvcprojectortools

Apache License 2.0
12 stars 8 forks source link

Enable jvcprojectortools to be imported and used by other Python modules #22

Open Ben-Mathews opened 4 years ago

Ben-Mathews commented 4 years ago

I want to use jvcprojectortools as part of an EventGhost plug-in to control a JVC projector, but the way the project currently relies on a config file to store hostname and port number prevents me from doing so. I submitted this pull request https://github.com/arvehj/jvcprojectortools/pull/21 which adds an optional host_port_str parameter to JVCNetwork's init() to specify these rather than having to read from a config file. The original functionality is retained if this paramter is not passed in. I also updated the README.md to reflect this new option.

BTW, thanks for sharing your project!

arvehj commented 4 years ago

Sounds good, but I requested some changes on your pull request.