search

arvehj / jvcprojectortools

Apache License 2.0
12 stars 8 forks source link

Add menu item that allows user to import custom gamma curve from .jgd file #6

Open ogkenobi opened 7 years ago

ogkenobi commented 7 years ago

Allow user to import a 256-point custom gamma curve created using jvcprojectortools to be imported to projector via external file (.jgd)

arvehj commented 7 years ago

The .jgd files created by and imported by the jvc autocal software don't have 256 points in them. As far as I know the autocal software cannot import a file if you add any points, so I don't see much reason to create 256 point .jgd files.

I do have pending changes that allow you to load and save json formatted files though. If all you want is the ability to save and load files created by jvcprojectortools, and not this specific file format, then what you want should soon be available.

dcchan2 commented 7 years ago

Hi, Please consider adding an option to save and upload .jgd files. For owners of the older (2014) JVC projectors, currently there is no way to upload a custom gamma to the projector. Thanks.

arvehj commented 7 years ago

I don't know how to interpret the .jpg files. They only have a few control points. What do you want the values in-between set to? I could interpolate, but the result may not match what autocal does. If you want to upload a custom curve that you cannot generate with this tool, you can currently do that if you edit the .conf file and reload it. You have to set all 256 points though.

dcchan2 commented 7 years ago

The 2015+ jvc autocal software itself only provides 12 control points for gamma, and the .jgd file contains the 12 y-values which can be uploaded to the software. I'm not sure what the projector does with the remainder of the 256 points, but that's not my concern. I am simply looking for an equivalent function for the 2014 projectors, since their autocal software does not include the .jgd upload function.

Thanks.

arvehj commented 7 years ago

The projector only accepts curves with 256 points. I cannot provide the equivalent function without knowing how those points are calculated from the values in the .jgd file.

I could probably figure this out by uploading a curve with autocal and downloading the 256 point curve, but I don't see a lot of value in this, so I'm not prepared to spend much time on this. If you can provide the mapping function though, I can add an import option.

dcchan2 commented 7 years ago

I had assumed (incorrectly) that autocal uploads the 12 values to the projector. Based on what you just said, the software apparently interpolates the 12 values to 256 points prior to uploading; then indeed it would not be worthwhile to duplicate the function. However, the JSON import/export function you mentioned before would still be useful for people to share information.

Thanks for the excellent work. On Sun, Mar 12, 2017 at 10:37 PM Arve Hjønnevåg notifications@github.com wrote:

The projector only accepts curves with 256 points. I cannot provide the equivalent function without knowing how those points are calculated from the values in the .jgd file.

I could probably figure this out by uploading a curve with autocal and downloading the 256 point curve, but I don't see a lot of value in this, so I'm not prepared to spend much time on this. If you can provide the mapping function though, I can add an import option.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/arvehj/jvcprojectortools/issues/6#issuecomment-286002374, or mute the thread https://github.com/notifications/unsubscribe-auth/AYx6SbO2bo46EuTSVZfhCBI-v8852kcAks5rlKv5gaJpZM4MFsDx .

dcchan2 commented 6 years ago

Hello Arve,

Thank you for the excellent JVC Projector Tool that has helped so many owners.

I've only started using it recently, and have come across a very minor issue: I was experimenting with SG, and tried 0 to see how it affects the curve. The tool returned the following message: 0.0 < 0.0001 clip_gamma [0.0001,10000.0]

which implies the lower legal limit is 0.0001. However, entering any value less than 0.001 would lead to a "float division by 0".

This may be of no practical concern, but I thought I should report it.

Thanks again. Dominic Chan

On Mon, Mar 13, 2017 at 12:12 AM, GDC goggled@gmail.com wrote:

I had assumed (incorrectly) that autocal uploads the 12 values to the projector. Based on what you just said, the software apparently interpolates the 12 values to 256 points prior to uploading; then indeed it would not be worthwhile to duplicate the function.

Thanks for the excellent work. On Sun, Mar 12, 2017 at 10:37 PM Arve Hjønnevåg notifications@github.com wrote:

The projector only accepts curves with 256 points. I cannot provide the equivalent function without knowing how those points are calculated from the values in the .jgd file.

I could probably figure this out by uploading a curve with autocal and downloading the 256 point curve, but I don't see a lot of value in this, so I'm not prepared to spend much time on this. If you can provide the mapping function though, I can add an import option.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/arvehj/jvcprojectortools/issues/6#issuecomment-286002374, or mute the thread https://github.com/notifications/unsubscribe-auth/AYx6SbO2bo46EuTSVZfhCBI-v8852kcAks5rlKv5gaJpZM4MFsDx .