search

arveoncode / relink-damage

https://relink-damage.vercel.app
6 stars 1 forks source link

Charlotta Warpath not working #36

Closed DarxZalor closed 3 months ago

arveoncode commented 3 months ago

I've added Charlotta's 10% enhanced dmg to all skill modifiers with the "In Noble Stance" substring, but I'm not sure if that's the entirety of the buff. Please check the application if the calculations seem correct 😅

DarxZalor commented 3 months ago

Checked against Maygi's calc and in-game. It looks correct except under Basic Attack -> Continuous attacks the value (assuming all damage caps and warpath) should increase from 54088 to 59495 (or 59497 with Maygi's calc but the difference is small enough that it doesn't matter).

arveoncode commented 3 months ago

Fixed Charlotta's calculations now! Please check again 😅 Application wasn't computing all affected Charlotta's skills due to addition of "Sp" skill classification not being implemented after the patch.

DarxZalor commented 3 months ago

Looks good! Thanks!

arveoncode commented 3 months ago

Closing this issue now, thank you so much!!!