Closed schultzm closed 4 years ago
Thanks for the suggestion. I will take a look at this. The color choice is not optimally implemented, so might take too much work for me at this point. I started to restructure the coloring code last year but that was too much of an effort at the time unfortunately.
Hi @schultzm ! I implemented a new option for alignment output: -d or --dotted. I think this addresses your feature request #2.
I did not work on user control for colors, but switched blue for cyan in the output. In my terminals the blue was pretty good, but so is cyan. Hopefully that helps you.
I have made v1.5 available on PyPI, so just pip install --upgrade alv
. It would be good with some quick feedback on the implementation, if you can help me with that.
Best, Lars
Hi @arvestad
I was following this issue since the color issue had happened to me as well. The upgrade was very cool and enhanced the visualization of DNA sequences. However, when watching protein sequences. The dark blue is still there for some AA and the cyan is already taken by some others. Not sure if this was an expected output.
Regarding the --dotted
option. It seems that the first codon doesn't display a white background and then the dots are unperceived in the first column, and other thing I could spot is that the bases are dark blue under this option:
Cheers, Camilo.
Hi @arvestad ,
Thanks for addressing these requests so quickly. We are using your software to visualise primer alignments for COVID19. I have installed the update. A lot of improvements are there. It seems that the white color on the dots doesn't spill over into the bottom sequences and doesn't propagate past an IUPAC code and the nice DNA colors don't happen when the sequence type is auto-detected (probably due to IUPAC codes in my sequences) (see screenshots).
The nice colors do happen when I use the -t dna
option:
In my forked copy of alv, I found the magenta instead of red looked better than red.
Hi,
I only changed colors for DNA, because the color usage is a bit different with the 20 amino acids, so that was expected. Not sure how work it. Have you tried the Taylor color scheme, for example? I don’t mind adding another (preferably standard) color scheme if you have one for amino acids.
Codon alignments are view using the amino acid color schemes, so no change was intended there. The other effects (black starting background etc) are however unintended effects (i.e., bugs). Will try to take care of that this weekend.
Thanks a lot! L
19 mars 2020 kl. 16:34 skrev Camilo García notifications@github.com:
Hi @arvestad https://github.com/arvestad I was following this issue since the color issue had happened to me as well. The upgrade was very cool and enhanced the visualization of DNA sequences. However, when watching protein sequences. The dark blue is still there for some AA and the cyan is already taken by some others. Not sure if this was an expected output.
https://user-images.githubusercontent.com/25586362/77083740-f8b35000-69cb-11ea-81b4-7911b9807a8c.png Regarding the --dotted option. It seems that the first codon doesn't display a white background and then the dots are unperceived in the first column, and other thing I could spot is that the bases are dark blue under this option:
https://user-images.githubusercontent.com/25586362/77084526-1208cc00-69cd-11ea-8e10-195ba5181a3e.png Cheers, Camilo.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arvestad/alv/issues/11#issuecomment-601247075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIQWBXXLDB2KMGHWTFQ4PTRII3RDANCNFSM4LO3GY7A.
Yes, so the white starting background is a bug, but the unchanged color when auto detecting sequence type is not a bug but a feature, sorry, and I am not inclined to change that. You found the workaround that I think makes most sense. I am however happy to add another color scheme for amino acids though, if you have one to suggest. Do note that you can try ”-c taylor” now, if that would help?
Thanks for reporting the background bug. Hope to fix that this weekend.
best,
Lars
20 mars 2020 kl. 01:10 skrev Mark Schultz notifications@github.com:
Hi @arvestad https://github.com/arvestad ,
Thanks for addressing these requests so quickly. We are using your software to visualise primer alignments for COVID19. I have installed the update. A lot of improvements are there. It seems that the white color on the dots doesn't spill over into the bottom sequences and doesn't propagate past an IUPAC code and the nice DNA colors don't happen when the sequence type is auto-detected (probably due to IUPAC codes in my sequences) (see screenshots). https://user-images.githubusercontent.com/5474971/77125496-059e7500-6a9a-11ea-984e-a6b00477e561.png The nice colors do happen when I use the -t dna option:
https://user-images.githubusercontent.com/5474971/77125850-45199100-6a9b-11ea-981b-7efd494aa973.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arvestad/alv/issues/11#issuecomment-601472550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIQWBUEBECQ42DGBPMOTUTRIKX5TANCNFSM4LO3GY7A.
Hi @schultzm and @camilogarciabotero ,
I think the colouring bug is fixed now. Have a look (pip install --upgrade alv
) and please let me know how it goes.
Lars
Hi arvestad,
Thanks again for this program. Feature requests: 1) Allow user to change base colours (it's difficult to see black text on a dark blue background)
; 2) allow user to set first sequence as reference so that other seqs can be viewed with masked bases, so the above alignment would only have
.
for each base in all but the first sequence. Or like this:All the best,