search

arvgta / ajaxify

Ajaxify - An Ajax Plugin
https://4nf.org/
275 stars 124 forks source link

Fix click link with hash #102

Closed NZX-DeSiGN closed 8 years ago

NZX-DeSiGN commented 8 years ago

Hi,

I use css modal box with hash to target the box and there was a few bugs. hashChange was not true when hash was empty (#), so the page was refreshing, that's why I modified this method. And the return false cancel link events firing. Tell me what do you think about it and tell me if I do not understand how Ajaxify works !

Commit : Fix click link with hash

Change hashChange in hasHash and just check for a # in link (empty anchor # return true) Change return false in true in click handler to let link events fire

arvgta commented 8 years ago

Thanks very much, Nicolas! First of all, this branch is broken for some reason. Furthermore, what happens when there is a link to a different page, that has a hash? Hence, I would like to close this to be safe... We can re-open a more differentiated pull request, ok?