search

arvidjaar / bootinfoscript

71 stars 20 forks source link

Bash < 4.2 does _not_ support negative values for substring expansion #6

Closed 0rbiter closed 6 years ago

0rbiter commented 7 years ago

Change line 3564 for POSIX compatibility to: VM_Size=${LVM2_LV_SIZE%?};

instead of VM_Size=${LVM2_LV_SIZE:0:-1} This might work on bash < 4.2 when using MacOS but e.g. not on Bash 4.1.2(1) @ RHEL 6.8

ASSUMING THIS IS INTENDED TO REMOVE THE LAST CHARACTER "S" from the LVM SIZE IN SECTORS

arvidjaar commented 7 years ago

Substring extraction appeared in bash 2.0; are you sure your problem is caused by it?

0rbiter commented 7 years ago

negative values since 4.2... Am 03.05.2017 19:06 schrieb "Andrei Borzenkov" notifications@github.com:

Substring extraction appeared in bash 2.0; are you sure your problem is caused by it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arvidjaar/bootinfoscript/issues/6#issuecomment-298973855, or mute the thread https://github.com/notifications/unsubscribe-auth/AL5nVO4Yi0uvHmnsWNhgDhrdRxc_Whn4ks5r2LQmgaJpZM4NPlPH .

arvidjaar commented 7 years ago

Could you test https://github.com/arvidjaar/bootinfoscript/tree/issue/6 - I do not have LVM right now?

0rbiter commented 7 years ago

tomorrow, yes. Am 03.05.2017 19:51 schrieb "Andrei Borzenkov" notifications@github.com:

Could you test https://github.com/arvidjaar/bootinfoscript/tree/issue/6 - I do not have LVM right now?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arvidjaar/bootinfoscript/issues/6#issuecomment-298985784, or mute the thread https://github.com/notifications/unsubscribe-auth/AL5nVPH9Om3lihSLXgUnlhb5yymA0zn4ks5r2L6ugaJpZM4NPlPH .