search

arvidn / libtorrent

an efficient feature complete C++ bittorrent implementation
http://libtorrent.org
Other
5.28k stars 997 forks source link

Bug: DHT doesn't work under any proxy #6053

Closed master255 closed 2 years ago

master255 commented 3 years ago

@arvidn libtorrent version (or branch): any

platform/architecture: any

compiler and compiler version: any

DHT doesn't work under any proxy. A continuation of this problem: https://github.com/arvidn/libtorrent/issues/4078

arvidn commented 3 years ago

please be more specific

master255 commented 3 years ago

@arvidn I used the WinGate proxy server with the latest, working version of the library 1.2.13. I've tried all combinations of proxies. DHT doesn't work. I checked DHT with get and put commands.

master255 commented 3 years ago

@arvidn I just checked. In Utorrent DHT works through socks4 proxy. Libtorrent does not. I used similar settings and the same proxy.

master255 commented 3 years ago

@arvidn I checked how Libretorrent works. There proxy never starts at startup and if it is applied after startup, DHT doesn't work. Proxy in Libtorrent does not work for DHT. Arvin, fix it. This is important.

master255 commented 3 years ago

@arvidn There are a lot of problems:

  1. It is necessary setting to disable proxy for DHT. Because, for me, without a proxy DHT works, but peers do not. With a proxy, peers work, but DHT does not. Through the trackers the download goes, but this is not enough.
  2. DHT does not work through any proxies. Fixing this is more difficult, it seems to me.
  3. DHT should not be proxied through HTTP proxies. Right now, with an HTTP proxy, DHT stops working.
  4. i2p proxies don't work either. But this is the lowest priority.
arvidn commented 3 years ago

can you provide a wireshark dump of the packets sent to and from the SOCKS5 proxy?

master255 commented 3 years ago

@arvidn Adding torrents does not cause new traffic. I used this filter: ((ip.dst == 192.168.1.101) && (ip.src == 192.168.1.100)) || ((ip.dst == 192.168.1.100) && (ip.src == 192.168.1.101)) proxy port 4449 123.zip

arvidn commented 3 years ago

This message is the SOCKS5 handshake. I don't see the proxy respond.

05 01 00

I also don't see any UDP traffic going to the proxy, presumably because it got stuck handshaking.

The server is definitely supposed to respond, but it isn't. The protocol is specified here.

Are you sure your proxy is supposed to support SOCKS5?

master255 commented 3 years ago

@arvidn This is the first proxy server to be found in a Google search. Wingate - you can install it yourself and check it out. It's free. 321313123

I made a mistake last time. The proxy service was disabled. I just recorded a log with the service turned on. UTorrent doesn't work with Socks 5 either. But with Socks 4 it works for sure. 123.zip

master255 commented 3 years ago

@arvidn image

arvidn commented 3 years ago

as you can see in your wireshark dump, the exact same behavior is exhibited. The proxy server does not respond to the SOCKS5 handshake. Perhaps you could try to use SOCKS4 instead.

master255 commented 3 years ago

@arvidn Similarly, it doesn't work with SOCKS4. I checked all kinds of proxies.

arvidn commented 3 years ago

Do any of them respond to the SOCKS handshake?

master255 commented 3 years ago

@arvidn I don't understand and I don't know. How can I check it? Wouldn't it be better if you checked it yourself? I spent all evening trying to set up a proxy for DHT. And it didn't work.

arvidn commented 3 years ago

it works in my test: https://github.com/arvidn/libtorrent/blob/RC_2_0/simulation/test_transfer.cpp#L325

Seeker2 commented 3 years ago

I made a mistake last time. The proxy service was disabled. I just recorded a log with the service turned on. UTorrent doesn't work with Socks 5 either. But with Socks 4 it works for sure.

It's possible that uTorrent is not using the Socks 4 proxy for its DHT, just bypassing it and using the regular IPv4 internet connection.

zero77 commented 3 years ago

this may be of help finding DHT download history for an ip. https://iknowwhatyoudownload.com/en/contacts/

master255 commented 3 years ago

@arvidn Okay. Give me the name of a proxy server (proxy server for Windows 10) which I can use with libtorrent? I tried WinGate. It doesn't work.

master255 commented 3 years ago

@arvidn This is a very big and important problem that needs to be dealt with more as a priority. It greatly affects propagation. Especially in Russia and similar countries. Don't tell me we have to invent a proxy server specifically for your library.

arvidn commented 3 years ago

please feel free to trouble shoot. You can collect a wireshark dump of libtorrent talking to a proxy and some other program talking to it (using UDP). That would be a good start to see if libtorrent speaks socks5 incorrectly.

ichorid commented 3 years ago

I confirm that DHT connections do not work through the SOCKS5 proxy. Tried client_test, does not work.

While investigating DNS leak in Tribler, my Wireshark dumps of client_test are showed that Libtorrent requests the DHT bootstrap servers directly (w/o proxy), no matter the proxy settings.

Here is the test line I used (using ssh to a VPS as the proxy): client_test --enable_upnp=0 --proxy_type=2 --proxy_port=12666 --proxy_hostnames=1 --proxy_peer_connections=1 --proxy_tracker_connections=1 --proxy_hostname=127.0.0.1 --force_proxy=1 ./<some.torrent>

Also, even with --enable_dht=0, the client still issues DNS lookups for DHT bootstrap servers.

arvidn commented 3 years ago

@ichorid would you mind creating a separate ticket for the DNS leak?

Have you seen any other application successfully tunnel UDP via an ssh proxy? (if so, I would be interested in seeing wireshark dumps)

ichorid commented 3 years ago

@ichorid would you mind creating a separate ticket for the DNS leak?

You're right! OpenSSH SOCKS5 implementation does not support UDP forwarding!

(I've checked their source code, not signs of UDP support)

I'll try to check it with Dante or something.

HanabishiRecca commented 3 years ago

Please just make an option to bypass the proxy for DHT. Because the most time proxy is needed just to reach trackers (blocked by ISP), not for the DHT nodes.

AllSeeingEyeTolledEweSew commented 3 years ago

FWIW: you can consider using docker to do complex networking management, if it fits your use case. It's a nice way to do app-specific networking that isn't normally possible with e.g. iptables.

I end up running torrent clients with docker run --net <vpn container>, which helps guarantee that all traffic from the client (and only that traffic) goes over the vpn.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

master255 commented 3 years ago

Still not working

ichorid commented 3 years ago

Could be actually related to #6512

master255 commented 3 years ago

double

proninyaroslav commented 2 years ago

@arvidn Are there plans to fix it?

arvidn commented 2 years ago

@proninyaroslav I have not observed the problem. Do you have a wireshark dump demonstrating the issue? Ideally I would have two wireshark dumps, the second one demonstrating the proxy successfully forwarding UDP packets (because it's so common among socks5 proxies not to support that)

proninyaroslav commented 2 years ago

I make some dumps here https://github.com/arvidn/libtorrent/issues/4078

Rollinnn commented 2 years ago

I second the suggestion for adding option to use direct connection for DHT even if proxy is used for connection to tracker/announcer.

Alexey104 commented 2 years ago

I confirm that DHT nodes are always 0 when using Shadowsocks SOCKS5 proxy(in UDP mode) for tracker connections.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.