arvidn / libtorrent

an efficient feature complete C++ bittorrent implementation
http://libtorrent.org
Other
5.16k stars 994 forks source link

Error in UDP documentation #7370

Open josecelano opened 1 year ago

josecelano commented 1 year ago

On the UDP docs: https://www.rasterbar.com/products/libtorrent/udp_tracker_protocol.html

The first field in the connection request is the protocol_id, not the connection_id.

image

https://www.bittorrent.org/beps/bep_0015.html

arvidn commented 1 year ago

I actually think it's deliberately named connection_id. You'll note that every request message has the same 3 first fields, and every response message has the same 2 first fields.

You're right that the value in that field is the protocol ID, but the field is the same regardless of which action is being requested.

josecelano commented 1 year ago

I actually think it's deliberately named connection_id. You'll note that every request message has the same 3 first fields, and every response message has the same 2 first fields.

You're right that the value in that field is the protocol ID, but the field is the same regardless of which action is being requested.

Thank you @arvidn, in the BEP 15 they call it protocol_id.

image

Unless you mean it's deliberately named on this particular implementation documentation.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.