search

arvind0598 / better-first-issues

Inspired by Good First Issues, this project aims to empower first-time contributors to find repositories and issues to contribute to.
https://better-first-issues.vercel.app
MIT License
4 stars 10 forks source link

removed the rendering of loading before user enters any data #13

Closed adil14788 closed 3 years ago

adil14788 commented 3 years ago

Stop showing 'loading' before the user enters any data.

bug removed

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arvind0598/better-first-issues/6n2DfwGqr46G4wWivLBoBtVvtJxJ
✅ Preview: https://better-first-issues-git-fork-adil14788-adil-arvind0598.vercel.app

arvind0598 commented 3 years ago

Hi @adil14788, please make sure you comment on the issue (#9) to have it assigned to yourself before you start working on it.

Also, please check that the commits you make reference the issue within the message.

That said, this commit is a bit odd, because it doesn't just remove the bug, it removes the entire loading feature - so now there's no loading screen at all. We don't want that to happen.

We want it to go: EMPTY -> LOADING -> SUCCESS

It currently goes: LOADING -> SUCCESS

Your commit makes it go: EMPTY -> SUCCESS

adil14788 commented 3 years ago

Sorry for the mistakes, actually I am new to open source therefore I directly made the pull request. i didn't knew we had to first comment on the issue and had it assigned to ourselves