search

arvind0598 / better-first-issues

Inspired by Good First Issues, this project aims to empower first-time contributors to find repositories and issues to contribute to.
https://better-first-issues.vercel.app
MIT License
4 stars 10 forks source link

Improve card and add dependencies #14

Closed EmmaDawsonDev closed 3 years ago

EmmaDawsonDev commented 3 years ago

I added extra information to the card and changed the styling slightly.

This PR fixes issue 4, 6 and 12.

Let me know if there's anything you want changing.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arvind0598/better-first-issues/4SzVDiGQx58HrCCBEJLLXjqMmez9
âś… Preview: https://better-first-issues-git-fork-emmalearnscode-i-66d899-arvind0598.vercel.app

EmmaDawsonDev commented 3 years ago

Are you able to see why the checks are failing?

arvind0598 commented 3 years ago

Yep. The reason it fails is because of the lint checks. You can run npm run lint locally to see those errors.

You can also just run npm run build locally to see the issues. They should ideally be the same as what Vercel is complaining about.

EmmaDawsonDev commented 3 years ago

Ok, I'll see if I can work out how to fix it, then update here when it's ready for review

arvind0598 commented 3 years ago

Most of those issues seem to be auto fixable, so an npm run lint:fix should take care of that for you.

You can use the ESLint plugin for VS Code for some good contextual help when you hover on the bits that are erroring out.

EmmaDawsonDev commented 3 years ago

Thanks for the tip! That fixed it :)

arvind0598 commented 3 years ago

This looks good to me, thanks @emmalearnscode. Just as an FYI though, please do try to stick to the commit message format outlined in the contributing guide.

EmmaDawsonDev commented 3 years ago

Thanks for the tip, I was working on a couple of different repos at the same time and must’ve got mixed up with how to write commit messages. I will definitely check more carefully from now on.