arvind0598 / better-first-issues

Inspired by Good First Issues, this project aims to empower first-time contributors to find repositories and issues to contribute to.

https://better-first-issues.vercel.app

MIT License

4 stars 10 forks source link

add: Adding styled-components and @types/styled-components #16

Closed GuScarpim closed 3 years ago

GuScarpim commented 3 years ago

Issue: https://github.com/arvind0598/better-first-issues/issues/12

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arvind0598/better-first-issues/87ugQ4nPZPWhJy2SY6dx1dyXARKN
✅ Preview: https://better-first-issues-git-fork-guscarpim-featur-dc17f2-arvind0598.vercel.app

arvind0598 commented 3 years ago

12 was already assigned to Emma, so ideally you wouldn't be working on it - adding @types/styled-components should have been a comment on the issue rather than a full blown PR. However, seeing as you've already done it, we can probably let this one slide. Thanks for the contribution, I'll merge it as part of #18.