arvind0598 / better-first-issues

Inspired by Good First Issues, this project aims to empower first-time contributors to find repositories and issues to contribute to.
https://better-first-issues.vercel.app
MIT License
4 stars 10 forks source link

The language badge should be left-aligned compared to the other badges. #5

Closed arvind0598 closed 3 years ago

arvind0598 commented 3 years ago

image

Currently, all the badges sit on the top-right of a card. I feel it would be visually easier to read if we could get the language badge to sit on the left. This should also correspond to the @todo within the BadgeProps type, in components/repository.tsx

adil14788 commented 3 years ago

Can I take this issue? @arvind0598

arvind0598 commented 3 years ago

Yep for sure, go for it @adil14788

adil14788 commented 3 years ago

Screenshot (6)

Currently, all the badges sit on the top-right of a card. I feel it would be visually easier to read if we could get the language badge to sit on the left.

So,all the badges are situated at the center ,and there is little space to make the language badge sit at the left @arvind0598 what should I do?? Can you help me?

arvind0598 commented 3 years ago

It doesn't look like you're on the latest version of the codebase. Make sure you do a git pull before starting development.

Here's what the screen looks like for me, after #14 got merged.

image

You'll notice they're all flex-aligned to the start (not the center), I'd expect the change to have all the badges aligned to the end, and the language to sit at the start all by itself.

arvind0598 commented 3 years ago

@emmalearnscode anything you'd wanna pitch in here to help @adil14788?

EmmaDawsonDev commented 3 years ago

Sure, at the moment all three are in one container, with flex-start. I suggest wrapping the second and third badge in a box so they are grouped, then change the flex to space-between

adil14788 commented 3 years ago

Thanks, @emmalearnscode for the guidance,this is what I have done is this fine @arvind0598 Screenshot (7)

arvind0598 commented 3 years ago

This looks great @adil14788, thankyou.