search

arvinddoraiswamy / mywebappscripts

A collection of all the lists, scripts and techniques I use while doing web application penetration tests.
MIT License
168 stars 80 forks source link

Regex compiling should only be done once #1

Closed SecurityForUs closed 11 years ago

SecurityForUs commented 11 years ago

Otherwise you're defeating the purpose of compiling regex at all. :)

arvinddoraiswamy commented 11 years ago

Ah thanks. I'll accept your change. I haven't used compile too often because all past code has been matching actual strings. This time I need to match against a variable..and had to use compile..and just did whatever worked quickly with Google's help :)

Thanks for the tip.

SecurityForUs commented 11 years ago

Compile works either way but its usually advisable to do compile than not. :) On Aug 31, 2013 11:40 PM, "arvinddoraiswamy" notifications@github.com wrote:

Ah thanks. I'll accept your change. I haven't used compile too often because all past code has been matching actual strings. This time I need to match against a variable..and had to use compile..and just did whatever worked quickly with Google's help :)

Thanks for the tip.

— Reply to this email directly or view it on GitHubhttps://github.com/arvinddoraiswamy/mywebappscripts/pull/1#issuecomment-23618392 .

arvinddoraiswamy commented 11 years ago

Cool. Will keep that in mind and get more familiar with it. Thanks :)