arvindm95 / unladen-swallow

Automatically exported from code.google.com/p/unladen-swallow
Other
0 stars 0 forks source link

Make 'make distclean' clean Util/llvm/ as well. #81

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Currently, 'make distclean' doesn't clean up anything in Util/llvm, which 
makes cleaning up after a change that breaks incremental builds is more 
painful than necessary. We should make the distclean target recurse into 
Util/llvm, and we may have to add a 'distclean' or 'allclean' target to LLVM 
(since it doesn't seem to have one.)

Original issue reported on code.google.com by thomaswout@gmail.com on 15 Sep 2009 at 11:55

GoogleCodeExporter commented 8 years ago
Hi thomaswout, 
 I went through 'Makefile' under the root directory of unladen and found that, the
'distclean' target has been added and it recursed into Util/llvm just like other
directories. It worked well as I tried.

 This issue has been fixed, right? 

Thanks,
Delian.

Original comment by delia...@gmail.com on 15 Dec 2009 at 8:20

GoogleCodeExporter commented 8 years ago
'make distclean' calls the 'clean' target which executes 'clean' in Util/llvm 
as well. So yes, 
this issue should be closed.

Original comment by bcannon on 22 Feb 2010 at 2:54

GoogleCodeExporter commented 8 years ago
Fixed in r1037.

Original comment by collinw on 22 Feb 2010 at 3:18

GoogleCodeExporter commented 8 years ago
So it looks like LLVM's own clean statement is lacking. If you run 'make 
distclean' it 
ends up leaving behind the following files:

?       Modules/libpython2.6.unopt.bc
?       Util/llvm/Makefile.config
?       Util/llvm/config.log
?       Util/llvm/mklib
?       Util/llvm/config.status
?       Util/llvm/llvm.spec
?       Util/llvm/include/llvm/Intrinsics.gen
?       Util/llvm/include/llvm/Config/AsmPrinters.def
?       Util/llvm/include/llvm/Config/Targets.def
?       Util/llvm/include/llvm/Config/config.h
?       Util/llvm/include/llvm/Config/AsmParsers.def
?       Util/llvm/include/llvm/Config/Disassemblers.def
?       Util/llvm/include/llvm/System/DataTypes.h
?       Util/llvm/tools/clang/include/clang/Driver/CC1Options.inc
?       Util/llvm/tools/clang/include/clang/Driver/Options.inc

Original comment by bcannon on 22 Feb 2010 at 3:19