arvindr21 / blueimp-file-upload-expressjs

A simple express module for integrating jQuery File Upload.
http://expressjs-fileupload.cloudno.de/
104 stars 69 forks source link

Broke dependencies into /lib and added unit tests #30

Closed mycaule closed 9 years ago

mycaule commented 9 years ago

I only restructured the code into 3 files and added tests. I also checked that everything still worked with the full project.

Please check that everything is fine for Amazon S3.

mycaule commented 9 years ago

I did end to end tests on Amazon S3 account this morning. Everything seems OK besides issue #31.

arvindr21 commented 9 years ago

@mycaule Yeah, I am still checking the same in my local. Will push the 2 fixes from #31 also along with this.

mycaule commented 9 years ago

What's the status on this?

arvindr21 commented 9 years ago

Do you think we need to keep the firstRefactor branch?

mycaule commented 9 years ago

Yes you can delete it. I still have to extract the aws-sdk dependency. It should be easy now.

arvindr21 commented 9 years ago

Ok, I will till that is done to push to NPM