search

arvindr21 / blueimp-file-upload-expressjs

A simple express module for integrating jQuery File Upload.
http://expressjs-fileupload.cloudno.de/
104 stars 69 forks source link

SSL support #6

Closed mycaule closed 10 years ago

mycaule commented 10 years ago

You need to uncomment lines 45-52 of the module to be able to use this module in https for your express app. It's not ok for users to have to go inside /node_modules to do that since npm install or npm update will break things.

The original code you forked from used options.ssl value to create the server. Now that your code doesn't really use options.ssl value anymore but only the fact that it is undefined, you can just replace it by a boolean options.useSSL that users can pass by parameter.

It's is now responsiblity of your package user to create the server anyway. He will be able to chose HTTP or HTTPS if he wants.

I can do the pull request and quick tests this week end if you want.

Regards, Michel.

arvindr21 commented 10 years ago

Please go ahead and submit a PR. Thanks.