add support for diskdb queries with multiple keys

arvindr21 / diskDB

A Lightweight Disk based JSON Database with a MongoDB like API for Node

http://arvindr21.github.io/diskDB

603 stars 65 forks source link

add support for diskdb queries with multiple keys #5

Closed samsel closed 10 years ago

samsel commented 10 years ago

the changes here honors all the keys in the given query object for filtering

arvindr21 commented 10 years ago

Hi @samsel Thanks for the PR.

Looking at the changes, you have modified the finder(). We have moved away from finder() in the last push. We are using an ObjectSearcher() to recursively fetch all the matched keys. Commit : https://github.com/arvindr21/diskDB/commit/3c43b816a0b7b5ba18c48e0594e520091855da26

Thanks.

samsel commented 10 years ago

i started off making changes to the util.removeFiltered function but ended up changing other utils as well, since the same logic could be written everywhere. so what is the recommendation? revert the changes to finder and keep the rest?

arvindr21 commented 10 years ago

@samsel : I am planning to move the other operations to use ObjectSearcher as well. I was waiting to see if anyone else reported any issue on find() or findone(). And looks like none so far. You can help me with that if interested. Thanks.

arvindr21 commented 10 years ago

Closing the PR for now.