search

arvindvyas / Country-State-Select

It will fetch the countries and according to that fetch the state of that countries, currently it is for countries listing
MIT License
69 stars 78 forks source link

Need to look how we can add more cities #25

Open arvindvyas opened 8 years ago

arvindvyas commented 8 years ago

Need to look city-state gem , for update cities , in our gem , currently I have seen there are lots of cities are not available , need to check how we can update that data

kxu1988 commented 8 years ago

gem countries(https://github.com/hexorx/countries) maybe a better choice, this gem maintains well.

"All sorts of useful information about every country packaged as convenient little country objects. It includes data from ISO 3166 (countries and states/subdivisions ), ISO 4217 (currency), and E.164 (phone numbers)."

arvindvyas commented 8 years ago

@kxu1988 thanks for suggestion but they don't provide cities , currently we are looking to add more cities .

matthewvb commented 8 years ago

I'm also interested in modifying this a bit. Looks like the source of cities / states is linked to https://github.com/loureirorg/city-state. Any plans to merge the db from city-state natively in the app?

@arvindvyas you could submit a pull request to https://github.com/loureirorg/city-state with the new cities you'd like listed.

Edit: found a bit more info on the db source and updated the comment. Added note about pull request.

arvindvyas commented 8 years ago

@matthewvb no plan yet to merge the cities to natively in the app.

I am looking to provide update city method from this gem.

wonderphil commented 7 years ago

Hi guys,

I just started using your gem, which by the way is awesome, so thanks. When I first started using it the city list was for the UK at least pretty much nothing. But looking at the city-state gem, I have just added a function that runs CS.update . This pretty much gave me all the city but only issue I found is it didn't remove any old mapping.

So not sure if this is a question for you or they guys who wrote city-state. any thoughts?

Thanks

Phil

arvindvyas commented 4 years ago

@wonderphil we are looking to move such functionality into our gem once that will be done we can commit anything on this, thanks