arvinj1 / libjingle

Automatically exported from code.google.com/p/libjingle
0 stars 0 forks source link

Incorrect prefixes on some xmpp elements #403

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use ping task and send a ping.

What is the expected output? What do you see instead?

inside the iq message should be:
<ping xmlns='urn:xmpp:ping'/>

Instead of:
<ping:ping xmlns:ping='urn:xmpp:ping'/>

this doesn't seem to work with my version of ejabberd. As well rfc only seems 
to talk about prefixing for very specific cases namely stream. Libjingle seems 
to prefix all elements based on last element in namespace. Maybe there's a part 
of the rfc that discusses the correctness of this approach but I haven't run 
across it yet.

What version of the product are you using? On what operating system?
Trunk

Please provide any additional information below.

Original issue reported on code.google.com by luke.we...@gmail.com on 22 Oct 2012 at 7:12

GoogleCodeExporter commented 9 years ago
Okay, think I've figured it out. It's probably only isolated to ping in this 
case as the other uses seem to be using the default namespace option on 
xmlelement. Diff to fix pingtask.cc is attached.

Original comment by l...@tuenti.com on 23 Oct 2012 at 8:07

Attachments: