arvinxx / dumi-theme-antd-style

dumi-theme for antd-style site
https://dumi-theme-antd-style.arvinx.com
MIT License
75 stars 37 forks source link

:bug: fix(slots-foolter-index): 修复Footer中支持自定义 columns 数据问题 #87

Closed huangjihua closed 9 months ago

huangjihua commented 10 months ago

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

  const columns =
    footer?.columns === false
      ? undefined
      : getColumns({ github: githubUrl || (pkg as any).homepage });

to

const columns = footer?.columns
    ? footer?.columns
    : getColumns({ github: githubUrl || (pkg as any).homepage });

📝 补充信息 | Additional Information

测试结果显示: image

vercel[bot] commented 10 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @arvinxx on Vercel.

@arvinxx first needs to authorize it.

arvinxx commented 10 months ago

这个逻辑有问题的。这样意味着默认不传就不显示,不符合预期

huangjihua commented 10 months ago

默认不配置 columns,会采用getColumns返回的数据,只有当 columns 配置为空数组情况底部才会没数据,我作为使用者来看,认为符合预期呀

arvinxx commented 10 months ago

默认不配置 columns,会采用getColumns返回的数据,只有当 columns 配置为空数组情况底部才会没数据,我作为使用者来看,认为符合预期呀

哦 我知道了,我理解错了。那你这么改的话,有个问题是,图标那些还是没法显示的,能接受么。这也是我之前没透传的原因

huangjihua commented 10 months ago

没图标也可以,如果需要图标话,可以处理下,如配置了 icons,由于rc-footer组件 icons 接受的是 ReactNode类型,所以这里还得处理下,有空我处理下图标问题。

arvinxx commented 10 months ago

没图标也可以,如果需要图标话,可以处理下,如配置了 icons,由于rc-footer组件 icons 接受的是 ReactNode类型,所以这里还得处理下,有空我处理下图标问题。

如果能接受没有图标的话,这个pr等ci过了我可以先合

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi-theme-antd-style ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 1:17pm
arvinxx commented 10 months ago

refs: https://github.com/umijs/umi/issues/11564

huangjihua commented 10 months ago

没图标也可以,如果需要图标话,可以处理下,如配置了 icons,由于rc-footer组件 icons 接受的是 ReactNode类型,所以这里还得处理下,有空我处理下图标问题。

如果能接受没有图标的话,这个pr等ci过了我可以先合

好的,感谢

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 0.29.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: