search

arvinxx / gitmoji-commit-workflow

😉 Gitmoji Commit Workflow
MIT License
217 stars 27 forks source link

`commitlint` dependency is redundant for `plugin-gitmoji` #470

Closed PAXANDDOS closed 1 year ago

PAXANDDOS commented 2 years ago

Hey! I'm new to the whole 'commitlint' thing and was messing around and found possibly redundant dependency.

commitlint@"^11.0.0 required by commitlint-plugin-gitmoji and' is required by commitlint-config-gitmoji seems to be redundant. Furthermore, even with installed commitlint, it would show an error that says I got the wrong version (required 11, latest 17).

So I got commitlint totally removed and ignored the warning message. And it works as expected! I got installed only @commitlint/cli (which seems to be the only package needed to get commitlint to work, according to official documentation), commitlint-config-gitmoji, and @commitlint/types (for config file).

Don't you find this dependency redundant? Or at least outdated

tianyingchun commented 1 year ago

yes, should remove this peerDependencies.

arvinxx commented 1 year ago

fixed in https://github.com/arvinxx/gitmoji-commit-workflow/releases/tag/commitlint-plugin-gitmoji%402.2.1