search

arvinxx / gitmoji-commit-workflow

😉 Gitmoji Commit Workflow
MIT License
213 stars 26 forks source link

Commitlint plugin does not recognize ⬆️ #492

Closed jpolo closed 1 year ago

jpolo commented 2 years ago

The bug concerns the commitlint plugin/config.

I usea custom config available in this repository. It is possible to reproduce the bug by changing the value of anyGitmoji to '⬆️'.

The validation message is "Your commit should start with gitmoji code,please check the emoji code on https://gitmoji.dev/."

jpolo commented 2 years ago

Could reproduce with 🩹, so it seems to be a wider problem...

jpolo commented 1 year ago

It seems that using is-fullwidth-code-point And replacing the unicodeRegex with unicodeResult = raw.split('').filter(isFullwidthCodePoint); would validate the commit message. Would you accept a PR, or is this repo dead ?

srizzon commented 1 year ago

I have the same problem with 🧪 and 🏗️.

I found this regex (line 10) and I made a list of all emojis based on this json and a lot of emojis doesn't match with this regex.

Sample: https://regex101.com/r/BS5M9a/1

This regex work as well: https://regex101.com/r/R7drml/2 but I'm not sure about this solution.

mehdicopter commented 1 year ago

I found this as well, and I think this project is dead :/

arvinxx commented 1 year ago

fixed in commitlint-plugin-gitmoji@2.2.5